[PATCH] D20608: clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811)
Nico Weber via cfe-commits
cfe-commits at lists.llvm.org
Wed May 25 12:43:54 PDT 2016
thakis accepted this revision.
This revision is now accepted and ready to land.
================
Comment at: lib/Sema/SemaTemplate.cpp:7382
@@ +7381,3 @@
+ if (A->getKind() == AttributeList::AT_DLLExport) {
+ // dllexport trumps dllexport here.
+ DLLImport = false;
----------------
trumps _dllimport_ here
(test?)
================
Comment at: lib/Sema/SemaTemplate.cpp:7451
@@ -7423,1 +7450,3 @@
+ HasNoEffect = false;
+ }
}
----------------
does moving this here change behavior? if so, maybe add a test for that too.
http://reviews.llvm.org/D20608
More information about the cfe-commits
mailing list