[PATCH] D20621: [include-fixer] Create a mode in vim integration to show multiple potential headers.

Benjamin Kramer via cfe-commits cfe-commits at lists.llvm.org
Wed May 25 12:31:14 PDT 2016


bkramer added inline comments.

================
Comment at: include-fixer/tool/clang-include-fixer.py:84
@@ +83,3 @@
+    index = 1;
+    for header in lines[1:]:
+      choices_message += "&" + str(index) + header + "\n"
----------------
ioeric wrote:
> If there is only one candidate, it doesn't make sense to ask users to choose it IMO. We can simply insert the header in this case.
> 
> And I think we should make users pick the correct header if there are multiple candidates by default. What do you think, Ben? @bkramer
I agree, we should ask by default when there is more than one suggested header.


http://reviews.llvm.org/D20621





More information about the cfe-commits mailing list