[PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

[Pirama Arumuga Nainar via cfe-commits]

pirama added a comment.

To summarize, there are two scenarios where a warning is warranted when the source language is OpenCL:

> > I'm not suggesting it be treated as invalid. This extension is part of at least OpenCL 2.1, but it's not part of OpenCL 1.0. `ext_vector_type` is Clang's implementation of the OpenCL vector type. Therefore if the user asks us to support OpenCL 1.0, we should give them a warning if they use this syntax.

> 




- use of ext_vector_type in OpenCL 1.0 and earlier.

> To avoid confusion, I'd like to note that rgba selector was first introduced in OpenCL C++ kernel language, which is currently in provisional state and will be part of OpenCL version 2.2.




- use of rgba selector in OpenCL 2.1 and earlier.

I'll look at how to add the first warning.  I'll most probably upload a separate CL for this.

I can easily add the second warning in this CL - to emit one on *any* OpenCL source.  Alexey: can you take care of revising this warning when OpenCL2.2 is added as a langugage standard?


http://reviews.llvm.org/D20602