[PATCH] D20334: [libcxx] Fix a bug in strstreambuf::overflow
Ben Craig via cfe-commits
cfe-commits at lists.llvm.org
Wed May 25 08:29:49 PDT 2016
bcraig added a comment.
In http://reviews.llvm.org/D20334#438052, @ahatanak wrote:
> My understanding is that typically std::ends is explicitly appended to null-terminate the stream buffer. The test case in the example does that.
>
> http://en.cppreference.com/w/cpp/io/ostrstream/str
Doh! You're right.
I'm still confused though, so please entertain my blind fumblings.
ASAN is complaining about an excessively large read. If the problem was in overflow, I would expect ASAN to complain about an out-of-bounds write instead.
http://reviews.llvm.org/D20334
More information about the cfe-commits
mailing list