[PATCH] D19105: Changes in clang after running http://reviews.llvm.org/D18821

Piotr Padlewski via cfe-commits cfe-commits at lists.llvm.org
Wed May 25 03:18:42 PDT 2016


Prazek added inline comments.

================
Comment at: include/llvm-c/Core.h:604
@@ -603,3 +603,3 @@
  */
-LLVMBool LLVMPrintModuleToFile(LLVMModuleRef M, const char *Filename,
+bool LLVMPrintModuleToFile(LLVMModuleRef M, const char *Filename,
                                char **ErrorMessage);
----------------
deadalnix wrote:
> Please keep LLVMBool in the C API. ABI change are a NO NO.
As I said in my comment, I won't commit most of the changes. This review is only to show what check has found.


http://reviews.llvm.org/D19105





More information about the cfe-commits mailing list