[PATCH] D20573: [libcxx] Allow explicit pthread opt-in

[Asiri Rathnayake via cfe-commits]

rmaprath added a comment.

Couple of minor comments. LGTM otherwise.

/ Asiri


================
Comment at: CMakeLists.txt:387
@@ -386,2 +386,3 @@
 
+config_define_if(LIBCXX_HAS_PTHREAD_API _LIBCPP_HAS_THREAD_API_PTHREAD)
 config_define_if(LIBCXX_HAS_MUSL_LIBC _LIBCPP_HAS_MUSL_LIBC)
----------------
I think we should put in a check to make sure that `LIBCXX_HAS_PTHREAD_API` is only enabled when `LIBCXX_ENABLE_THREADS` is also enabled.

================
Comment at: include/__config:816
@@ -815,3 +815,3 @@
 // Thread API
-#ifndef _LIBCPP_HAS_NO_THREADS
+#if !defined(_LIBCPP_HAS_NO_THREADS) && !defined(_LIBCPP_HAS_THREAD_API_PTHREAD)
 # if defined(__FreeBSD__) || \
----------------
Similarly here. For example, there is a similar check for `_LIBCPP_HAS_NO_MONOTONIC_CLOCK` compatibility with the `LIBCXX_ENABLE_THREADS` flag.


http://reviews.llvm.org/D20573