[PATCH] D20447: [OpenCL] Fixup extension list

Jan Vesely via cfe-commits cfe-commits at lists.llvm.org
Tue May 24 10:24:56 PDT 2016


jvesely added inline comments.

================
Comment at: test/SemaOpenCL/extension-version.cl:11
@@ +10,3 @@
+#endif
+#pragma OPENCL EXTENSION cl_clang_storage_class_specifiers: enable
+
----------------
Anastasia wrote:
> Could you use standard diagnostic check please:
>   expected-warning{{unknown OpenCL extension ...
> 
> Similarly to SemaOpenCL/extensions.cl
not sure I follow, the test does not trigger any diagnostics (by design).
are you saying that I should introduce negative checks to make sure extensions are not available outside of their respective context?
Is there a way to filter verifier tags based on clang invocation? (something like FileCheck prefix)


Repository:
  rL LLVM

http://reviews.llvm.org/D20447





More information about the cfe-commits mailing list