[PATCH] D20249: [OpenCL] Hierarchical/dynamic parallelism - enqueue kernel in OpenCL 2.0

[Anastasia Stulova via cfe-commits]

Anastasia marked 6 inline comments as done.

================
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7820
@@ -7819,3 +7819,3 @@
   "kernel must have void return type">;
 def err_sampler_argument_required : Error<
   "sampler_t variable required - got %0">;
----------------
It's not used actually!

================
Comment at: lib/CodeGen/CGBuiltin.cpp:2150
@@ +2149,3 @@
+
+    if (NumArgs == 4) {
+      // The most basic form of the call with parameters:
----------------
yaxunl wrote:
> Can we remove the non-vararg version and keep only the vararg version? The vararg can be empty, so the non-vararg version is redundant.
We still need it for checking the parameters of blocks are 'local void*'.

Also I am not sure there is a way to combine Clang builtin and non-builtin prototype for the same function easily...


http://reviews.llvm.org/D20249