[PATCH] D20243: [PCH] Disable inclusion of timestamps when generating pch files on windows.

pierre gousseau via cfe-commits cfe-commits at lists.llvm.org
Tue May 24 02:14:08 PDT 2016


pgousseau added a comment.

In http://reviews.llvm.org/D20243#437192, @thakis wrote:

> Hm, the ASTReader code this works around is over 6 years old (r100866). Maybe we could try enabling the access time check instead?


Yes the issue described in ASTReader lacks a reproducible so it makes sense to tentatively re-enabling the timestamp check on windows. If the issue still occurs on some bots then at least we can document the issue better before re-disabling it.

I also would like to provide a switch to disable inclusion of timestamps. I will hopefully be proposing a patch for it soon.


http://reviews.llvm.org/D20243





More information about the cfe-commits mailing list