[PATCH] D20496: [include-fixer] Added find-stl-symbols to retrieve symbols (with the correct include header name) from C++ standard STL headers.

[Haojian Wu via cfe-commits]

hokein added inline comments.

================
Comment at: include-fixer/find-stl-symbols/STLSymbolsFinder.h:25
@@ +24,3 @@
+///
+/// To decide which symbols can be #include'd from each headear, we run
+/// FindSTLSymbolsAction on each header to retrieve all symbols in the
----------------
s/headear/header

================
Comment at: include-fixer/find-stl-symbols/STLSymbolsFinder.h:97
@@ +96,3 @@
+  STLReporter Reporter;
+  /// Wether to run clang tool in verbose mode.
+  bool Verbose;
----------------
s/wether/whether

================
Comment at: include-fixer/find-stl-symbols/tool/FindSTLSymbolsMain.cpp:32
@@ +31,3 @@
+    CXXIncludePath("i", cl::desc("C++ standard library include path. Headers "
+                                 "under this directory will be processed."),
+                   cl::init(""), cl::value_desc("libc++ include path"));
----------------
It would be  clearer to add an example path here.

================
Comment at: include-fixer/find-stl-symbols/tool/FindSTLSymbolsMain.cpp:37
@@ +36,3 @@
+    OutputFile("o", cl::desc("The file path for saving the results."),
+               cl::init("stl-symbols.yaml"),
+               cl::value_desc("output-file.yaml"));
----------------
Using underscore `stl_symbols_db.yaml` to keep consistence with `find_all_symbols_db.yaml`.


http://reviews.llvm.org/D20496