[PATCH] D20519: [clang-tidy] Ignore ADL-style using decls in unused-using-decls check.

Haojian Wu via cfe-commits cfe-commits at lists.llvm.org
Mon May 23 06:39:43 PDT 2016


hokein added inline comments.

================
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:47
@@ +46,3 @@
+      return;
+    // Ignores using-declarations defined in function definitions to avoid
+    // arguement-dependent lookup.
----------------
alexfh wrote:
> I don't think using declarations in functions are inherently related to ADL. This check doesn't seem like a useful heuristic.
Yeah, the current work around is only to ignore all using-decls in function context which is not perfect. I didn't find out a better way.


http://reviews.llvm.org/D20519





More information about the cfe-commits mailing list