[PATCH] D20500: [ms] Allow more unqualified lookup of types in dependent base classes
Richard Smith via cfe-commits
cfe-commits at lists.llvm.org
Fri May 20 17:43:23 PDT 2016
rsmith added inline comments.
================
Comment at: lib/Parse/ParseDecl.cpp:2282
@@ -2281,3 +2281,3 @@
// Otherwise, if we don't consume this token, we are going to emit an
// error anyway. Try to recover from various common problems. Check
----------------
Maybe put the check here instead. That way, you can apply it for any DSContext.
================
Comment at: lib/Sema/SemaDecl.cpp:507
@@ +506,3 @@
+findRecordParentWithDependentBases(const DeclContext *DC) {
+ for (;; DC = DC->getLookupParent()) {
+ DC = DC->getPrimaryContext();
----------------
Missing loop termination condition
http://reviews.llvm.org/D20500
More information about the cfe-commits
mailing list