[PATCH] D20415: Update Clang for D20147 ("DebugInfo: New metadata representation for global variables.")

[Adrian Prantl via cfe-commits]

aprantl added inline comments.

================
Comment at: lib/CodeGen/CGDebugInfo.cpp:3393
@@ +3392,3 @@
+        DContext, FieldName, LinkageName, Unit, LineNo, FieldTy,
+        Var->hasInternalLinkage(), nullptr, nullptr);
+    Var->addDebugInfo(GV);
----------------
Is there a good reason for not changing the DIBuilder interface to drop the global field?

================
Comment at: lib/CodeGen/CGDebugInfo.cpp:3477
@@ -3473,1 +3476,3 @@
+    InitExpr =
+        DBuilder.createConstantValueExpression(Init.getInt().getExtValue());
   GV.reset(DBuilder.createGlobalVariable(
----------------
Are we regressing floating point constants here?


http://reviews.llvm.org/D20415