[PATCH] D20424: [include-fixer] Make search handle fully qualified names correctly.

Haojian Wu via cfe-commits cfe-commits at lists.llvm.org
Thu May 19 05:46:10 PDT 2016


hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.

LGTM with one nit.


================
Comment at: include-fixer/SymbolIndexManager.cpp:73
@@ +72,3 @@
+        if (IsFullyQualified)
+          IsMatched &= SymbolContext == Symbol.getContexts().end();
+
----------------
Might be `IsMatched &= (SymbolContext == Symbol.getContexts().end());` for reading clearly?


http://reviews.llvm.org/D20424





More information about the cfe-commits mailing list