[PATCH] D20119: [libunwind] Improve unwinder stack usage

[Asiri Rathnayake via cfe-commits]

rmaprath updated this revision to Diff 57487.
rmaprath added a comment.

Addressing review comments from @jroelofs:

- Moved the assertion in `libunwind.cpp` back to `UnwindCursor.cpp` where it really belogs.

@jroelofs: I just realized that, with this new native-only build of `libunwind`, users of `libunwind.h` would have to explicitly `#define` the flag `_LIBUNWIND_IS_NATIVE_ONLY` in order to get the header in-sync with the library. I can't see an immediate problem if they don't define that flag though, it's just that they'll end up passing larger buffers than the library needs. Do you see a problem here?

'libc++' uses a `__config_site` mechanism to wire the cmake build options into the `__config` file. We can implement a similar mechanism in `libunwind`, not sure if that's necessary here.

WDYT?

Thanks.

/ Asiri


http://reviews.llvm.org/D20119

Files:
  CMakeLists.txt
  include/__libunwind_config.h
  include/libunwind.h
  src/CompactUnwinder.hpp
  src/Registers.hpp
  src/UnwindCursor.hpp
  src/config.h
  src/libunwind.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D20119.57487.patch
Type: text/x-patch
Size: 16008 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160517/baefd487/attachment-0001.bin>