[PATCH] D20329: [clang-include-fixer] Added Vim integration for clang-include-fixer.

Eric Liu via cfe-commits cfe-commits at lists.llvm.org
Tue May 17 08:21:54 PDT 2016


ioeric added inline comments.

================
Comment at: include-fixer/tool/ClangIncludeFixer.cpp:51
@@ +50,3 @@
+cl::opt<bool>
+    VimMode("vim",
+            cl::desc("Run the tool on a potentially unsaved buffer from Vim"),
----------------
hokein wrote:
> bkramer wrote:
> > This isn't really specific to vim, we should name it differently. '-stdin' maybe? Then document what it really does.
> I think we can make the include-fixer accept stdin input by default if there is no command-line file path. In this case, there is no need to add a command-line option here.
We can't get the compile options for the code if we only accept <stdin> input (without the corresponding file path).


http://reviews.llvm.org/D20329





More information about the cfe-commits mailing list