[PATCH] D20137: [PCH] Fixed bugs with preamble invalidation when files change (on Windows)
Richard Smith via cfe-commits
cfe-commits at lists.llvm.org
Fri May 13 16:26:47 PDT 2016
rsmith added inline comments.
================
Comment at: lib/Frontend/ASTUnit.cpp:1402-1406
@@ +1401,7 @@
+
+ vfs::Status Status;
+ if (FileMgr->getNoncachedStatValue(RB.first, Status)) {
+ AnyFileChanged = true;
+ break;
+ }
+
----------------
Suppose file names A and B refer to file (inode) X, and the map contains X -> (A, hash). If B is deleted (and maybe recreated pointing at a new inode), this approach won't detect that anything has changed.
http://reviews.llvm.org/D20137
More information about the cfe-commits
mailing list