[PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

[Aaron Ballman via cfe-commits]

aaron.ballman added a subscriber: aaron.ballman.

================
Comment at: lib/Driver/MSVCToolChain.cpp:42
@@ -40,1 +41,3 @@
+
+  #pragma comment(lib, "version.lib")
 #endif
----------------
Eh, I am lightening up on this sort of thing, so this is fine by me.

================
Comment at: lib/Driver/MSVCToolChain.cpp:467
@@ +466,3 @@
+  std::string BinPath;
+  if (!getVisualStudioBinariesFolder("", BinPath)) {
+    return Version;
----------------
Elide braces (here and elsewhere) per usual project coding conventions.

================
Comment at: lib/Driver/MSVCToolChain.cpp:483
@@ +482,3 @@
+  }
+  std::vector<char> VersionBlock(VersionSize);
+  if (!::GetFileVersionInfoW(ClExeWide.c_str(), 0, VersionSize,
----------------
Pure pedantry: `uint8_t` instead of `char`, or is this data really a textual string in practice?


http://reviews.llvm.org/D20136