[PATCH] D20180: [tooling] Fix missing inline keyworkd, breaking build bot.

Etienne Bergeron via cfe-commits cfe-commits at lists.llvm.org
Wed May 11 12:26:52 PDT 2016


etienneb created this revision.
etienneb added a reviewer: rnk.
etienneb added a subscriber: cfe-commits.
Herald added a subscriber: klimek.

The missing keyword "inline" is causing some buildbot to fail.
The symbol is not available.

see: http://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage/builds/2281/

http://reviews.llvm.org/D20180

Files:
  include/clang/Tooling/FixIt.h

Index: include/clang/Tooling/FixIt.h
===================================================================
--- include/clang/Tooling/FixIt.h
+++ include/clang/Tooling/FixIt.h
@@ -40,27 +40,27 @@
 
 /// \brief Returns the SourceRange of an given Node. \p Node is typically a
 ///        'Stmt', 'Expr' or a 'Decl'.
-template <typename T> SourceRange getSourceRange(const T &Node) {
+template <typename T> inline SourceRange getSourceRange(const T &Node) {
   return Node.getSourceRange();
 }
 } // end namespace internal
 
 // \brief Returns a textual representation of \p Node.
 template <typename T>
-StringRef getText(const T &Node, const ASTContext &Context) {
+inline StringRef getText(const T &Node, const ASTContext &Context) {
   return internal::getText(internal::getSourceRange(Node), Context);
 }
 
 // \brief Returns a FixItHint to remove \p Node.
 // TODO: Add support for related syntactical elements (i.e. comments, ...).
-template <typename T> FixItHint createRemoval(const T &Node) {
+template <typename T> inline FixItHint createRemoval(const T &Node) {
   return FixItHint::CreateRemoval(internal::getSourceRange(Node));
 }
 
 // \brief Returns a FixItHint to replace \p Destination by \p Source.
 template <typename D, typename S>
-FixItHint createReplacement(const D &Destination, const S &Source,
-                            const ASTContext &Context) {
+inline FixItHint createReplacement(const D &Destination, const S &Source,
+                                   const ASTContext &Context) {
   return FixItHint::CreateReplacement(internal::getSourceRange(Destination),
                                       getText(Source, Context));
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D20180.56949.patch
Type: text/x-patch
Size: 1661 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160511/a78b5b32/attachment.bin>


More information about the cfe-commits mailing list