[PATCH] D19274: Compilation for Intel MCU (Part 2/3)

[Bruno Cardoso Lopes via cfe-commits]

bruno added a comment.

Hi,


================
Comment at: include/clang/Basic/DiagnosticDriverKinds.td:154
@@ -153,1 +153,3 @@
+def err_drv_cxx_not_supported : Error<
+  "C++ is not supported for target '%0'">;
 
----------------
Are you sure there's no equivalente for this already? I'm surprised!

================
Comment at: lib/Driver/Tools.cpp:300
@@ -299,1 +299,3 @@
+  const bool IsIAMCU = getToolChain().getTriple().isOSIAMCU();
+
   CheckPreprocessingOptions(D, Args);
----------------
Tidy up this declaration with others, no need for two newlines here.

================
Comment at: lib/Driver/Tools.cpp:575
@@ -569,1 +574,3 @@
+  else
+    getToolChain().AddIAMCUIncludeArgs(Args, CmdArgs);
 
----------------
Use braces for the "else" and move the comment somewhere inside the braces


http://reviews.llvm.org/D19274