[PATCH] D20170: [clang-tidy] TypeTraits - Type is not expensive to copy when it has a deleted copy constructor.

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Wed May 11 09:39:10 PDT 2016


alexfh added inline comments.

================
Comment at: clang-tidy/utils/TypeTraits.cpp:20
@@ -18,1 +19,3 @@
 
+using namespace ::clang::ast_matchers;
+
----------------
aaron.ballman wrote:
> I would prefer this be used locally instead of at namespace scope to avoid potential name collisions.
Note, that file-level `using namespace ast_matchers` is rather common in Clang tools, so I wouldn't bother here. That said, I'm fine either way.


Repository:
  rL LLVM

http://reviews.llvm.org/D20170





More information about the cfe-commits mailing list