[PATCH] D20158: [find-all-symbols] Save relative file path for each symbol.
Benjamin Kramer via cfe-commits
cfe-commits at lists.llvm.org
Wed May 11 04:43:42 PDT 2016
bkramer added inline comments.
================
Comment at: include-fixer/find-all-symbols/SymbolInfo.h:81
@@ -81,1 +80,3 @@
+ /// \brief The file path where the symbol comes from. It's a relative file
+ /// path based on the build directory.
std::string FilePath;
----------------
hokein wrote:
> One question is that whether should we add a `BuildDir` in `SymbolInfo`. With `BuildDir`, we can check the build directory in include-fixer make sure they are the same :).
Hmm. If both the symbol finder and include fixer run on the same compilation database this can never happen, right?
Repository:
rL LLVM
http://reviews.llvm.org/D20158
More information about the cfe-commits
mailing list