[PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

[Aaron Ballman via cfe-commits]

On Tue, May 10, 2016 at 6:09 PM, Adrian McCarthy via cfe-commits
<cfe-commits at lists.llvm.org> wrote:
> amccarth added inline comments.
>
> ================
> Comment at: lib/Driver/MSVCToolChain.cpp:472
> @@ +471,3 @@
> +
> +  const DWORD VersionSize = ::GetFileVersionInfoSizeA(ClExe.c_str(), nullptr);
> +  if (VersionSize == 0) {
> ----------------
> majnemer wrote:
>> Why not use the `GetFileVersionInfoSizeW` variant?
> I started down that road, but it seemed overkill to convert the path to a wide string.  I'm happy to do it if you think it worthwhile.

Please use the W version instead of the A version. Not everyone
installs to the default path, and non-ASCII characters happen.

~Aaron

>
>
> http://reviews.llvm.org/D20136
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits