[PATCH] D20045: [ObjC][CodeGen] Remove an assert that is no longer correct.

[Manman Ren via cfe-commits]

manmanren added a comment.

After r231508 made changes to promote constant temporaries to globals, the assert fires when a std::initializer_list is constructed using Objective-C string literals.

--> Can you explain the code path after r231508 for your example? Will r231508 change the code path if we start with a global?
r231508 seems to change the behavior constant temporaries only.

Thanks for working on this!
Manman


================
Comment at: lib/CodeGen/CGExpr.cpp:364
@@ +363,3 @@
+
+      if (Var->hasInitializer())
+        return MakeAddrLValue(Object, M->getType(), AlignmentSource::Decl);
----------------
Can you add comments here?


http://reviews.llvm.org/D20045