[PATCH] D19816: [find-all-symbols] Add IWYU private pragma support.

Haojian Wu via cfe-commits cfe-commits at lists.llvm.org
Mon May 9 07:42:14 PDT 2016


hokein marked an inline comment as done.

================
Comment at: include-fixer/find-all-symbols/PragmaCommentHandler.cpp:27
@@ +26,3 @@
+  SmallVector<StringRef, 4> Matches;
+  if (!llvm::Regex(IWYUPragma).match(Text, &Matches))
+    return false;
----------------
bkramer wrote:
> Isn't this regex just a complex way to write Text.find(IWYUPragma)?
Oh, didn't notice that. Yeah, we can use the `find` to handle the case.for now.


http://reviews.llvm.org/D19816





More information about the cfe-commits mailing list