[PATCH] D19962: [scan-build] fix warnings emitted on Clang StaticAnalyzer code base

[Apelete Seketeli via cfe-commits]

apelete added inline comments.

================
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:300
@@ -299,2 +299,3 @@
 
+  assert(SM && "SourceManager is NULL, cannot iterate through the diagnostics");
 
----------------
dblaikie wrote:
> This assertion seems to be equivalent to replacing the prior 'if' with an assertion of the same condition, no? Is that correct? (& if it is, we should just do that)
You're right, I overlooked the simplification.
Will fix in next revision.


http://reviews.llvm.org/D19962