[PATCH] D19105: Changes in clang after running http://reviews.llvm.org/D18821

JF Bastien via cfe-commits cfe-commits at lists.llvm.org
Thu May 5 12:36:40 PDT 2016


jfb added inline comments.

================
Comment at: lib/Transforms/IPO/MergeFunctions.cpp:147
@@ -146,3 +146,3 @@
   struct Config : ValueMapConfig<GlobalValue*> {
-    enum { FollowRAUW = false };
+    enum { FollowRAUW = 0 };
   };
----------------
This change should go to ValueMap, I think it should be moved to an enum class, and all uses of ValueMap should be changed accordingly. This is meant to act as a bool IMO, it's odd to make it otherwise.


http://reviews.llvm.org/D19105





More information about the cfe-commits mailing list