[PATCH] D19962: [scan-build] fix warnings emitted on Clang StaticAnalyzer code base

David Blaikie via cfe-commits cfe-commits at lists.llvm.org
Thu May 5 11:01:54 PDT 2016


dblaikie added a subscriber: dblaikie.

================
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:300
@@ -299,2 +299,3 @@
 
+  assert(SM && "SourceManager is NULL, cannot iterate through the diagnostics");
 
----------------
This assertion seems to be equivalent to replacing the prior 'if' with an assertion of the same condition, no? Is that correct? (& if it is, we should just do that)


http://reviews.llvm.org/D19962





More information about the cfe-commits mailing list