[PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL header file.

Yaxun Liu via cfe-commits cfe-commits at lists.llvm.org
Thu May 5 07:47:49 PDT 2016


yaxunl added a comment.

In http://reviews.llvm.org/D18369#421963, @pxli168 wrote:

> If we want to save some space, could we use some macro to expand the gentype or some script to expand the gentype into each types when the clang is build?


We need to balance between space and readability. When I absorbed __attribute__((overloadable)) into __const_func to save space, it did not sacrifice readability. However using macro with gentype will cause the header file more difficult to read.


http://reviews.llvm.org/D18369





More information about the cfe-commits mailing list