[PATCH] D16962: clang-tidy: avoid std::bind

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Wed May 4 13:43:02 PDT 2016


aaron.ballman added inline comments.

================
Comment at: clang-tidy/readability/ReadabilityTidyModule.cpp:17
@@ -15,2 +16,2 @@
 #include "ContainerSizeEmptyCheck.h"
 #include "DeletedDefaultCheck.h"
----------------
jbcoe wrote:
> aaron.ballman wrote:
> > I believe we use "modernize" to really mean "migrate from the old way to the new way", which this definitely fits into since I think the point to this check is to replace bind with better alternatives.
> Would you prefer it to be in `modernize`? I can be easily convinced either way and am happy to move it. If I do move it I might add a script to facilitate doing so.
My preference is for modernize, your preference is for readability, so I say: make @alexfh the tie-breaker! ;-) Alex, what are your thoughts? This seems like a heuristic we may want to state in our documentation to help others decide where to put new checks in the future as well.


http://reviews.llvm.org/D16962





More information about the cfe-commits mailing list