[PATCH] D19920: [libunwind][ARM] Improve unwinder stack usage on baremetal targets - part 1

Asiri Rathnayake via cfe-commits cfe-commits at lists.llvm.org
Wed May 4 07:59:24 PDT 2016


rmaprath added a comment.

In http://reviews.llvm.org/D19920#421131, @t.p.northover wrote:

> I think it would be better to use a generic method so the size is minimal everywhere rather than making ARM a special case. Possibly move the #define bits from libunwind.cpp to __libunwind_config.h and use REGISTER_KIND to declare unw_context_t?


Wouldn't this make `libunwind.h` depend on `Registers_xxx` types? I thought the whole idea of statically allocated buffers was to keep these two separate. I may be wrong though, pretty new to unwinder.

Thanks.

/ Asiri


http://reviews.llvm.org/D19920





More information about the cfe-commits mailing list