[PATCH] D19913: Added static creators that create complete instances of SymbolInfo.

Haojian Wu via cfe-commits cfe-commits at lists.llvm.org
Wed May 4 07:40:50 PDT 2016


hokein added a comment.

It looks good to me now, but need to wait @klimek acceptance.


================
Comment at: include-fixer/find-all-symbols/SymbolInfo.h:98-101
@@ +97,6 @@
+
+  static SymbolInfo
+  CreateFunctionSymbolInfo(const std::string &Name, const std::string &FilePath,
+                           const std::vector<Context> &Contexts, int LineNumber,
+                           const FunctionInfo &FuncInfo);
+
----------------
However, changing `SymbolInfo` to class requires us to add many setters/getters in it.

Currently the `SymbolInfo` is like `ClangTidyOptions` structure. 


http://reviews.llvm.org/D19913





More information about the cfe-commits mailing list