[PATCH] D19816: [find-all-symbols] Add IWYU private pragma support.

[Manuel Klimek via cfe-commits]

klimek added inline comments.

================
Comment at: include-fixer/find-all-symbols/FindAllSymbols.h:48
@@ +47,3 @@
+  explicit FindAllSymbols(ResultReporter *Reporter,
+                          HeaderMapCollector *Collector)
+      : Reporter(Reporter), Collector(Collector) {}
----------------
I'd pass in the HeaderMap here.

================
Comment at: include-fixer/find-all-symbols/PragmaCommentHandler.h:22
@@ +21,3 @@
+
+/// \brief PragmaCommentHandler handle all pragma comment. It supports a way for
+/// clients to control their include path.
----------------
"PragmaCommentHandler handle all pragma comment"
This comment doesn't really tell me anything new.

Perhaps:
PragmaCommentHandler parses comments on include files to determine when we should include a different header from the header that directly defines a symbol.

================
Comment at: unittests/include-fixer/find-all-symbols/FindAllSymbolsTests.cpp:418
@@ +417,3 @@
+
+  {
+    SymbolInfo Symbol =
----------------
Any reason for the extra block here?


http://reviews.llvm.org/D19816