[PATCH] D19881: clang-cl: Print a blank line at the start of /showIncludes (PR27226)

[Nico Weber via cfe-commits]

thakis added a comment.

In http://reviews.llvm.org/D19881#420245, @hans wrote:

> In http://reviews.llvm.org/D19881#420244, @thakis wrote:
>
> > I agree with Brad that it'd be nice if we didn't have to add this :-)
> >
> > What's the workaround for current cmake releases?
>
>
> Passing -DCMAKE_CL_SHOWINCLUDES_PREFIX="Note: including file: " is the work-around I used.
>
> I just figured that if this is easy to fix, it would be nice for clang-cl users who don't have a bleeding-edge CMake version.


So ninja knows how to filter out the source line that cl.exe prints unconditionally, without a way to disable that. If you add a bare newline, ninja won't filter that out and this will add an empty line to each compile step run under ninja. To work around that, you could print the source input file, but that seems very undesirable.

So I think doing nothing (and documenting the workaround somewhere) is probably the best path forward :-/


http://reviews.llvm.org/D19881