[PATCH] D19866: [Analyzer] Correct stack address escape diagnostic
Anna Zaks via cfe-commits
cfe-commits at lists.llvm.org
Tue May 3 09:09:53 PDT 2016
zaks.anna added a comment.
Thanks for fixing!
Devin, what do you think about the BugType wording?
================
Comment at: llvm/tools/clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp:229
@@ -228,3 +228,3 @@
BT_stackleak.reset(
- new BuiltinBug(this, "Stack address stored into global variable",
- "Stack address was saved into a global variable. "
+ new BuiltinBug(this, "Stack address stored into global/static variable",
+ "Stack address was saved into a global/static variable. "
----------------
I don't like the '/' here. The only idea I have is to replace it with "into a variable with static allocation", which is also not ideal because it uses jargon.
http://reviews.llvm.org/D19866
More information about the cfe-commits
mailing list