[PATCH] D19484: [OpenCL] Add supported OpenCL extensions to target info.

[Yaxun Liu via cfe-commits]

yaxunl added inline comments.

================
Comment at: test/CodeGenOpenCL/builtins-r600.cl:2
@@ -1,3 +1,3 @@
 // REQUIRES: amdgpu-registered-target
-// RUN: %clang_cc1 -triple r600-unknown-unknown -S -emit-llvm -o - %s | FileCheck %s
+// RUN: %clang_cc1 -triple r600-unknown-unknown -target-cpu rv670 -S -emit-llvm -o - %s | FileCheck %s
 
----------------
Anastasia wrote:
> Just triple is not sufficient here? 
This test requires fp64 support. Some GPUs of r600 target does not support fp64. Need to specify a GPU supporting fp64.

================
Comment at: test/SemaOpenCL/extensions.cl:14
@@ +13,3 @@
+#ifdef NOFP64
+// expected-warning at -2{{unknown OpenCL extension 'cl_khr_fp64' - ignoring}}
+#endif
----------------
Anastasia wrote:
> I was just wondering whether renaming to "unsupported" instead of "unknown" would make more sense?
Agree.


http://reviews.llvm.org/D19484