[PATCH] D19483: docs: Update SafeStack docs with separate-stack-seg feature and various USP storage modes

Peter Collingbourne via cfe-commits cfe-commits at lists.llvm.org
Sat Apr 30 14:27:13 PDT 2016


pcc added a comment.

You should be using `-target x86-unknown-contiki` or similar. That should tune the behaviour to what is required for that OS. See what we have in `TargetLoweringBase::getSafeStackPointerLocation` to provide Android-specific behaviour for example.

The existence of flags is not justification to add more. Besides, it appears that the `-safe-stack-usp-storage` flag was added without proper review. It was reviewed in http://reviews.llvm.org/D15673, but the mailing list was not added as a subscriber. If I had been aware of that review I would have made the same objections at that time.


http://reviews.llvm.org/D19483





More information about the cfe-commits mailing list