[PATCH] D19625: [libc++] Void-cast runtime-unused variables.

[David Blaikie via cfe-commits]

I'm not sure why we'd want to compile the test suite with -Wunused-variable
(& even if we did, I imagine Clang's doesn't fire here because the
variables are used, just in non-evaluated contexts?)? Is there a benefit to
it being clean of unused-variable warnings? (in Clang's test case we just
aggressively disable warnings rather than making all the code warning
clean, for example)

On Fri, Apr 29, 2016 at 4:23 PM, Stephan T. Lavavej via cfe-commits <
cfe-commits at lists.llvm.org> wrote:

> STL_MSFT updated the summary for this revision.
> STL_MSFT updated this revision to Diff 55683.
> STL_MSFT added a comment.
>
> This moves "str" as requested. It also adds void casts to another file,
> and removes an unused argc/argv pair.
>
>
> http://reviews.llvm.org/D19625
>
> Files:
>   test/std/depr/depr.c.headers/setjmp_h.pass.cpp
>   test/std/depr/depr.c.headers/stdio_h.pass.cpp
>   test/std/input.output/file.streams/c.files/cstdio.pass.cpp
>
> test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/minus1.pass.cpp
>
> test/std/iterators/iterator.primitives/std.iterator.tags/bidirectional_iterator_tag.pass.cpp
>
> test/std/iterators/iterator.primitives/std.iterator.tags/forward_iterator_tag.pass.cpp
>
> test/std/iterators/iterator.primitives/std.iterator.tags/input_iterator_tag.pass.cpp
>
> test/std/iterators/iterator.primitives/std.iterator.tags/output_iterator_tag.pass.cpp
>
> test/std/iterators/iterator.primitives/std.iterator.tags/random_access_iterator_tag.pass.cpp
>
> test/std/language.support/support.exception/except.nested/throw_with_nested.pass.cpp
>
> test/std/language.support/support.exception/propagation/current_exception.pass.cpp
>   test/std/language.support/support.runtime/csetjmp.pass.cpp
>   test/std/language.support/support.runtime/ctime.pass.cpp
>   test/std/localization/c.locales/clocale.pass.cpp
>
> test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_long_double.pass.cpp
>   test/std/numerics/cfenv/cfenv.syn/cfenv.pass.cpp
>   test/std/numerics/rand/rand.device/eval.pass.cpp
>   test/std/re/re.alg/re.alg.search/grep.pass.cpp
>   test/std/strings/c.strings/cwchar.pass.cpp
>
> test/std/utilities/allocator.adaptor/allocator.adaptor.types/allocator_pointers.pass.cpp
>   test/std/utilities/memory/default.allocator/allocator_pointers.pass.cpp
>   test/std/utilities/time/date.time/ctime.pass.cpp
>   test/std/utilities/utility/forward/forward.pass.cpp
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160429/7ab1dd99/attachment.html>