[PATCH] D19590: Check for CERT ERR34-C. Detect errors when converting a string to a number

[Aaron Ballman via cfe-commits]

aaron.ballman closed this revision.
aaron.ballman marked 3 inline comments as done.
aaron.ballman added a comment.

Thanks! I've commit in r268100 with the changes you requested.


================
Comment at: clang-tidy/cert/StrToNumCheck.cpp:182
@@ +181,3 @@
+void StrToNumCheck::check(const MatchFinder::MatchResult &Result) {
+  const auto *CE = Result.Nodes.getNodeAs<CallExpr>("expr");
+  const FunctionDecl *FD = nullptr;
----------------
alexfh wrote:
> Too many abbreviations for my taste. How about CE -> Call, FD -> Function or FuncDecl, CK -> Conversion, CFD -> ConverterFunc?
My Clang-isms are spilling over. ;-) I've converted to the more verbose names.


http://reviews.llvm.org/D19590