[PATCH] D19739: Add a loop's debug location to its llvm.loop metadata

[Hal Finkel via cfe-commits]

hfinkel created this revision.
hfinkel added reviewers: rsmith, rjmccall, aprantl, dblaikie, echristo, anemet.
hfinkel added a subscriber: cfe-commits.
Herald added subscribers: joker.eph, mcrosier.

Getting accurate locations for loops is important, because those locations are used by the frontend to generate optimization remarks. Currently, optimization remarks for loops often appear on the wrong line, often the first line of the loop body instead of the loop itself. This is confusing because that line might itself be another loop, or might be somewhere else completely if the body was inlined function call. This happens because of the way we find the loop's starting location. First, we look for a preheader, and if we find one, and its terminator has a debug location, then we use that. Otherwise, we look for a location on an instruction in the loop header.

The fallback heuristic is not bad, but will almost always find the beginning of the body, and not the loop statement itself. The preheader location search often fails because there's often not a preheader, and even when there is a preheader, depending on how it was formed, it sometimes carries the location of some preceeding code.

I don't see any good theoretical way to fix this problem. On the other hand, this seems like a straightforward solution: Put the debug location in the loop's llvm.loop metadata. When emitting debug information, this patch causes us to add the debug location as an operand to each loop's llvm.loop metadata. Thus, we now generate this metadata for all loops (not just loops with optimization hints) when we're otherwise generating debug information.

The remark test case changes depend on the companion LLVM patch D19738.


http://reviews.llvm.org/D19739

Files:
  lib/CodeGen/CGLoopInfo.cpp
  lib/CodeGen/CGLoopInfo.h
  lib/CodeGen/CGStmt.cpp
  lib/CodeGen/CGStmtOpenMP.cpp
  test/CodeGenCXX/debug-info-line-if.cpp
  test/Frontend/optimization-remark-options.c
  test/Misc/backend-optimization-failure.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D19739.55650.patch
Type: text/x-patch
Size: 11022 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160429/f76650ae/attachment-0001.bin>