[PATCH] D19717: [find-all-symbols] Fix racy yaml file writing.
Haojian Wu via cfe-commits
cfe-commits at lists.llvm.org
Fri Apr 29 03:20:08 PDT 2016
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Thanks! LGTM with one nit.
================
Comment at: include-fixer/find-all-symbols/SymbolInfo.h:92
@@ +91,3 @@
+/// \brief Write SymbolInfos to a stream (YAML format).
+bool WriteSymbolInfosToFile(llvm::raw_ostream &OS,
+ const std::set<SymbolInfo> &Symbols);
----------------
It would be better to change the function name to WriteSymbolInfosToStream.
http://reviews.llvm.org/D19717
More information about the cfe-commits
mailing list