[PATCH] D19678: Annotated-source optimization reports (a.k.a. "listing" files)

Hal Finkel via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 28 19:04:29 PDT 2016


hfinkel added a comment.

In http://reviews.llvm.org/D19678#416039, @hfinkel wrote:

> In http://reviews.llvm.org/D19678#415902, @rsmith wrote:
>
> > You give this example:
> >
> > >   343     |     Loc = ConvertBackendLocation(D, Context->getSourceManager());
> >
> > >       I   |           ^
> >
> > >       I   |                                     ^
> >
> >
> > How does this look for a case like `p->Foo()->Bar()` (where one or both of the calls are inlined)? Can we get the source location to point at the function name instead of the start of the expression to reduce the scope for ambiguity?
>
>
> That does not currently work very well (I assume this needs a backend fix, but I'll check).


Actually, it's a Clang problem. https://llvm.org/bugs/show_bug.cgi?id=27567


http://reviews.llvm.org/D19678





More information about the cfe-commits mailing list