[PATCH] D19702: [libcxx] [test] Fix get_temp_file_name() to compile for Windows.

Stephan T. Lavavej via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 28 18:34:51 PDT 2016


[David Majnemer]
> Er, I don't think mingw provides _mktemp_s.

Yeah, I don't know what needs to be done for MinGW. (I avoided using _mktemp for MSVC because I knew it would complain about "security".)

I am pretty sure that this code was already broken for MinGW - I grepped and found no inclusions of windows.h throughout the tests, and I believe that MinGW's io.h and other CRT headers don't declare the windows.h GetTempPath/etc. machinery that this was trying to use.

[Eric Fiselier]
> I went back to the old method for MinGW in r267968 just to be safe. Thanks for the input.

I should have done that in the first place to be non-intrusive. Sorry for the minor headache.

STL


More information about the cfe-commits mailing list