[PATCH] D19698: [libcxx] [test] Need to include <memory> for std::unique_ptr.

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 28 18:22:14 PDT 2016


EricWF added a comment.

In http://reviews.llvm.org/D19698#416315, @rsmith wrote:

> In http://reviews.llvm.org/D19698#416309, @EricWF wrote:
>
> > Most tests pretty much rely on <type_traits> getting dragged in indirectly, same thing with <memory> and the bits of <utility> we actually define in <type_traits>.
>
>
> There are also a few symbols that libc++ defines in the wrong header and then #includes into the right one. Any automated fix is going to mess up on those.


Ah, I stupidly assumed that the automatic fix would handle "std::" symbols based off of the spec and not the implementation.


http://reviews.llvm.org/D19698





More information about the cfe-commits mailing list