[PATCH] D19665: [ARM] Guard the declarations of f16 to f32 vcvt intrinsics in arm_neon.h by testing __ARM_FP

[Tim Northover via cfe-commits]

t.p.northover added a comment.

Couple of issues, as far as I can see:


================
Comment at: include/clang/Basic/arm_neon.td:710-711
@@ +709,4 @@
+  def VCVT_F32_F16 : SInst<"vcvt_f32_f16", "wd", "h">;
+  def VCVT_HIGH_F16_F32 : SOpInst<"vcvt_high_f16", "hmj", "Hf", OP_VCVT_NA_HI_F16>;
+  def VCVT_HIGH_F32_F16 : SOpInst<"vcvt_high_f32", "wk", "h", OP_VCVT_EX_HI_F32>;
+}
----------------
I think these _high variants are supposed to be AArch64-only.

================
Comment at: test/CodeGen/arm-negative-fp16.c:1
@@ +1,2 @@
+// RUN: %clang_cc1 -triple thumbv7-none-eabi %s -target-feature +neon -target-feature -fp16 -fsyntax-only -verify
+
----------------
This is a Sema test.


http://reviews.llvm.org/D19665