[PATCH] D19412: [libcxx] Refactor pthread usage - II

[Ben Craig via cfe-commits]

bcraig added a comment.

In http://reviews.llvm.org/D19412#414374, @rmaprath wrote:

> > On a bikeshed note: is `<__os_support>` the right name? Or should it be something like `<__thread>`  or `<__threading_support>`?
>
>
> I went with `__os_support`  in case if we'd want to group further external dependencies (like, for example, if some non-c POSIX calls are used in the upcoming `filesystem` library). I can revert back to `__threading_support` if that's preferred.
>
> Thanks.
>
> / Asiri


I don't particularly care for <__os_support> either.  Either of <__thread> or <__threading_support> are fine with me.

Note that there are already other OS specific calls that libcxx has to handle.  A lot of the locale code wants to use BSD style foo_l functions that are present on Linux.  I prefer to keep the locale code independent of the threading code, as the two don't overlap much.

For filesystem related items, I would expect those to go under <__filesystem> or <__filesystem_support>, or something similar.


http://reviews.llvm.org/D19412