r267858 - Addressed review's comments.

Eric Liu via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 28 00:51:47 PDT 2016


Author: ioeric
Date: Thu Apr 28 02:51:47 2016
New Revision: 267858

URL: http://llvm.org/viewvc/llvm-project?rev=267858&view=rev
Log:
Addressed review's comments.

Modified:
    cfe/trunk/lib/Format/AffectedRangeManager.h
    cfe/trunk/lib/Format/Format.cpp

Modified: cfe/trunk/lib/Format/AffectedRangeManager.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Format/AffectedRangeManager.h?rev=267858&r1=267857&r2=267858&view=diff
==============================================================================
--- cfe/trunk/lib/Format/AffectedRangeManager.h (original)
+++ cfe/trunk/lib/Format/AffectedRangeManager.h Thu Apr 28 02:51:47 2016
@@ -56,6 +56,7 @@ private:
   // Returns \c true if line or one if its children is affected.
   bool nonPPLineAffected(AnnotatedLine *Line,
                          const AnnotatedLine *PreviousLine);
+
   SourceManager &SourceMgr;
   const SmallVector<CharSourceRange, 8> Ranges;
 };
@@ -63,4 +64,5 @@ private:
 } // namespace format
 } // namespace clang
 
-#endif // LLVM_CLANG_LIB_FORMAT_WHITESPACEMANAGER_H
+#endif // LLVM_CLANG_LIB_FORMAT_AFFECTEDRANGEMANAGER_H
+#

Modified: cfe/trunk/lib/Format/Format.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Format/Format.cpp?rev=267858&r1=267857&r2=267858&view=diff
==============================================================================
--- cfe/trunk/lib/Format/Format.cpp (original)
+++ cfe/trunk/lib/Format/Format.cpp Thu Apr 28 02:51:47 2016
@@ -1460,7 +1460,7 @@ public:
               std::unique_ptr<FileManager> FileMgr,
               std::unique_ptr<SourceManager> VirtualSM,
               std::unique_ptr<DiagnosticsEngine> Diagnostics,
-              std::vector<CharSourceRange> CharRanges)
+              const std::vector<CharSourceRange> &CharRanges)
       : Style(Style), ID(ID), CharRanges(CharRanges.begin(), CharRanges.end()),
         SM(*VirtualSM), FileMgr(std::move(FileMgr)),
         VirtualSM(std::move(VirtualSM)), Diagnostics(std::move(Diagnostics)) {}




More information about the cfe-commits mailing list