[PATCH] D19552: Check 'r' and 'y specifiers of freebsd_kernel_printf format strings on PS4

Sunil Srivastava via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 26 15:29:39 PDT 2016


Sunil_Srivastava added a comment.

I had put these 'h' test lines to test the first of my changes, and this sufficed, but you are correct. I should add %y too. I am going to add '%hr' and '%hy'.


================
Comment at: test/Sema/format-strings-freebsd.c:39
@@ -35,1 +38,3 @@
+  freebsd_kernel_printf("%hr", h); // no-warning
+
   // %y expects an int
----------------
dim wrote:
> It's nice to add these for %r, but is there any reason you didn't add similar ones for %y? (This is just a minor nit.)
I had put these lines to test the first of my changes, and this sufficed, but you are correct. I should  add %y too.  I am going to add '%hr' and '%hy'.


http://reviews.llvm.org/D19552





More information about the cfe-commits mailing list