[libcxx] r267591 - Apparently XFAIL tests that are supposed to fail to compile can be problematic. They still get compiled, and if the compile succeeds, the buildbots complain. Replace the XFAIL with #error.
Marshall Clow via cfe-commits
cfe-commits at lists.llvm.org
Tue Apr 26 12:29:35 PDT 2016
Author: marshall
Date: Tue Apr 26 14:29:35 2016
New Revision: 267591
URL: http://llvm.org/viewvc/llvm-project?rev=267591&view=rev
Log:
Apparently XFAIL tests that are supposed to fail to compile can be problematic. They still get compiled, and if the compile succeeds, the buildbots complain. Replace the XFAIL with #error.
Modified:
libcxx/trunk/test/std/re/re.alg/re.alg.match/basic.fail.cpp
libcxx/trunk/test/std/re/re.alg/re.alg.search/basic.fail.cpp
libcxx/trunk/test/std/re/re.iter/re.regiter/re.regiter.cnstr/cnstr.fail.cpp
libcxx/trunk/test/std/re/re.iter/re.tokiter/re.tokiter.cnstr/array.fail.cpp
libcxx/trunk/test/std/re/re.iter/re.tokiter/re.tokiter.cnstr/init.fail.cpp
libcxx/trunk/test/std/re/re.iter/re.tokiter/re.tokiter.cnstr/int.fail.cpp
libcxx/trunk/test/std/re/re.iter/re.tokiter/re.tokiter.cnstr/vector.fail.cpp
Modified: libcxx/trunk/test/std/re/re.alg/re.alg.match/basic.fail.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/re/re.alg/re.alg.match/basic.fail.cpp?rev=267591&r1=267590&r2=267591&view=diff
==============================================================================
--- libcxx/trunk/test/std/re/re.alg/re.alg.match/basic.fail.cpp (original)
+++ libcxx/trunk/test/std/re/re.alg/re.alg.match/basic.fail.cpp Tue Apr 26 14:29:35 2016
@@ -18,12 +18,14 @@
// regex_constants::match_flag_type =
// regex_constants::match_default) = delete;
-// XFAIL: C++98, c++03, c++11
-
#include <regex>
#include <cassert>
#include "test_macros.h"
+#if TEST_STD_VER < 14
+#error
+#endif
+
int main()
{
{
Modified: libcxx/trunk/test/std/re/re.alg/re.alg.search/basic.fail.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/re/re.alg/re.alg.search/basic.fail.cpp?rev=267591&r1=267590&r2=267591&view=diff
==============================================================================
--- libcxx/trunk/test/std/re/re.alg/re.alg.search/basic.fail.cpp (original)
+++ libcxx/trunk/test/std/re/re.alg/re.alg.search/basic.fail.cpp Tue Apr 26 14:29:35 2016
@@ -18,12 +18,14 @@
// regex_constants::match_flag_type =
// regex_constants::match_default) = delete;
-// XFAIL: C++98, c++03, c++11
-
#include <regex>
#include <cassert>
#include "test_macros.h"
+#if TEST_STD_VER < 14
+#error
+#endif
+
int main()
{
{
Modified: libcxx/trunk/test/std/re/re.iter/re.regiter/re.regiter.cnstr/cnstr.fail.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/re/re.iter/re.regiter/re.regiter.cnstr/cnstr.fail.cpp?rev=267591&r1=267590&r2=267591&view=diff
==============================================================================
--- libcxx/trunk/test/std/re/re.iter/re.regiter/re.regiter.cnstr/cnstr.fail.cpp (original)
+++ libcxx/trunk/test/std/re/re.iter/re.regiter/re.regiter.cnstr/cnstr.fail.cpp Tue Apr 26 14:29:35 2016
@@ -17,12 +17,14 @@
// regex_constants::match_flag_type m =
// regex_constants::match_default) = delete;
-// XFAIL: C++98, c++03, c++11
-
#include <regex>
#include <cassert>
#include "test_macros.h"
+#if TEST_STD_VER < 14
+#error
+#endif
+
int main()
{
{
Modified: libcxx/trunk/test/std/re/re.iter/re.tokiter/re.tokiter.cnstr/array.fail.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/re/re.iter/re.tokiter/re.tokiter.cnstr/array.fail.cpp?rev=267591&r1=267590&r2=267591&view=diff
==============================================================================
--- libcxx/trunk/test/std/re/re.iter/re.tokiter/re.tokiter.cnstr/array.fail.cpp (original)
+++ libcxx/trunk/test/std/re/re.iter/re.tokiter/re.tokiter.cnstr/array.fail.cpp Tue Apr 26 14:29:35 2016
@@ -18,13 +18,15 @@
// regex_constants::match_flag_type m =
// regex_constants::match_default);
-// XFAIL: C++98, c++03, c++11
-
#include <regex>
#include <vector>
#include <cassert>
#include "test_macros.h"
+#if TEST_STD_VER < 14
+#error
+#endif
+
int main()
{
{
Modified: libcxx/trunk/test/std/re/re.iter/re.tokiter/re.tokiter.cnstr/init.fail.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/re/re.iter/re.tokiter/re.tokiter.cnstr/init.fail.cpp?rev=267591&r1=267590&r2=267591&view=diff
==============================================================================
--- libcxx/trunk/test/std/re/re.iter/re.tokiter/re.tokiter.cnstr/init.fail.cpp (original)
+++ libcxx/trunk/test/std/re/re.iter/re.tokiter/re.tokiter.cnstr/init.fail.cpp Tue Apr 26 14:29:35 2016
@@ -17,12 +17,14 @@
// regex_constants::match_flag_type m =
// regex_constants::match_default);
-// XFAIL: C++98, c++03, c++11
-
#include <regex>
#include <cassert>
#include "test_macros.h"
+#if TEST_STD_VER < 14
+#error
+#endif
+
int main()
{
{
Modified: libcxx/trunk/test/std/re/re.iter/re.tokiter/re.tokiter.cnstr/int.fail.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/re/re.iter/re.tokiter/re.tokiter.cnstr/int.fail.cpp?rev=267591&r1=267590&r2=267591&view=diff
==============================================================================
--- libcxx/trunk/test/std/re/re.iter/re.tokiter/re.tokiter.cnstr/int.fail.cpp (original)
+++ libcxx/trunk/test/std/re/re.iter/re.tokiter/re.tokiter.cnstr/int.fail.cpp Tue Apr 26 14:29:35 2016
@@ -16,12 +16,14 @@
// regex_constants::match_flag_type m =
// regex_constants::match_default);
-// XFAIL: C++98, c++03, c++11
-
#include <regex>
#include <cassert>
#include "test_macros.h"
+#if TEST_STD_VER < 14
+#error
+#endif
+
int main()
{
{
Modified: libcxx/trunk/test/std/re/re.iter/re.tokiter/re.tokiter.cnstr/vector.fail.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/re/re.iter/re.tokiter/re.tokiter.cnstr/vector.fail.cpp?rev=267591&r1=267590&r2=267591&view=diff
==============================================================================
--- libcxx/trunk/test/std/re/re.iter/re.tokiter/re.tokiter.cnstr/vector.fail.cpp (original)
+++ libcxx/trunk/test/std/re/re.iter/re.tokiter/re.tokiter.cnstr/vector.fail.cpp Tue Apr 26 14:29:35 2016
@@ -18,12 +18,14 @@
// regex_constants::match_flag_type m =
// regex_constants::match_default);
-// XFAIL: C++98, c++03, c++11
-
#include <regex>
#include <cassert>
#include "test_macros.h"
+#if TEST_STD_VER < 14
+#error
+#endif
+
int main()
{
{
More information about the cfe-commits
mailing list