[PATCH] D19547: [clang-tidy] Add FixIt for swapping arguments in string-constructor-checker.

Etienne Bergeron via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 26 11:29:01 PDT 2016


etienneb created this revision.
etienneb added a reviewer: alexfh.
etienneb added a subscriber: cfe-commits.

Arguments can be swapped using fixit when they are not in macros.
This is the same implementation than SwappedArguments. Some code 
got lifted to be reused.

Others checks are not safe to be fixed as they tend to be bugs or errors.
It is better to let the user manually review them.

http://reviews.llvm.org/D19547

Files:
  clang-tidy/misc/StringConstructorCheck.cpp
  clang-tidy/misc/SwappedArgumentsCheck.cpp
  clang-tidy/utils/FixItHintUtils.cpp
  clang-tidy/utils/FixItHintUtils.h
  test/clang-tidy/misc-string-constructor.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D19547.55053.patch
Type: text/x-patch
Size: 7252 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160426/f70bacf1/attachment.bin>


More information about the cfe-commits mailing list